Conversation
…older Replace AGP-template Greeting in MainActivity with a NavHost rooted at WelcomeScreen, with a channel_list placeholder destination. onPaired navigates to channel_list; onSetup is an inert TODO(#14) for the later external-browser intent. Closes #8 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
Code Review: #8Decision: PASS FindingsNone. SummaryImplementation matches the architect's spec exactly. All six acceptance criteria are satisfied:
Route strings centralised in a |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the AGP-template
Greeting("Android")inMainActivitywith aNavHostrooted atWelcomeScreenand adds achannel_listplaceholder destination.gradle/libs.versions.toml— addsnavigationCompose = "2.9.5"and theandroidx-navigation-composelibrary alias (Navigation Compose is not in the Compose BOM).app/build.gradle.kts— addsimplementation(libs.androidx.navigation.compose)(alphabetically placed; no inline version literal).MainActivity.kt— deletes the templateGreetingandGreetingPreview, introduces aprivatePyryNavHostthat ownsrememberNavController(), and aprivate object RouteswithWelcome/ChannelListstring constants.onPairednavigates tochannel_list;onSetupis a no-op with aTODO(#14)comment.Issue
Closes #8
Testing
./gradlew assembleDebug— passes (the only AC-binding gate)../gradlew test— passes../gradlew lint— passes (clean)../gradlew connectedAndroidTest— not run, no emulator/device attached in this environment.No navigation tests added per the spec's "Testing strategy" section (instrumentation tests deferred; spec explicitly says not to add
androidx-navigation-testingfor this ticket).Architecture compliance
Follows
docs/specs/architecture/8-navigation-compose-welcome-channellist-placeholder.mdexactly:PyryNavHostextracted as a private Composable insideMainActivity.kt, keepingsetContentat a single level of abstraction (theme → scaffold → nav host).private object Routes; nosealed class Route/ type-safe navigation refactor.onPaireduses plainnavController.navigate(Routes.ChannelList)— nopopUpTo/launchSingleTop. Back fromchannel_listreturns towelcome, as expected for this scaffolding ticket.channel_listroute renders bareText("Channel list placeholder")— noSurface, noScaffold, no padding, as specified.enableEdgeToEdge()and the outerScaffold(modifier = Modifier.fillMaxSize())preserved;WelcomeScreenis untouched.🤖 Generated with Claude Code