feat(ui): wire Welcome onSetup CTA to external browser (#14)#44
Merged
Conversation
Replace the TODO(#14) placeholder at the Routes.Welcome composable with an Intent.ACTION_VIEW launch of https://pyryco.de/setup via the Compose-local Context, mirroring the onPaired wiring shape. Closes #14 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
Code Review: #14Decision: PASS Findings
SummaryThe diff is minimal, focused, and matches the architecture spec line-for-line: file-scope
|
Adds docs/knowledge/codebase/14.md and refreshes welcome-screen.md + navigation.md to reflect that the onSetup CTA now launches Intent.ACTION_VIEW at https://pyryco.de/setup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the
TODO(#14)placeholder inMainActivity.kt'scomposable(Routes.Welcome)block with anIntent.ACTION_VIEWlaunch ofhttps://pyryco.de/setupviaLocalContext.current. The URL is held in a file-scopeprivate const val SetupUrlnext toRoutes.WelcomeScreen'sonSetup: () -> Unitparameter shape is unchanged; previews continue to passonSetup = {}no-ops.onPairedwiring pattern at the same call site.Intent,Uri, andLocalContextare already on the classpath.Issue
Closes #14
Testing
./gradlew assembleDebug— BUILD SUCCESSFUL./gradlew lint— BUILD SUCCESSFUL./gradlew test— BUILD SUCCESSFULArchitecture compliance
Follows the spec at
docs/specs/architecture/14-welcome-onsetup-external-browser.mdexactly:SetupUrlconstant adjacent toRoutes, not inside it.LocalContext.currentcaptured in thecomposable { ... }body and closed over by theonSetuplambda — same shape as thekoinInject/rememberCoroutineScopereads in the Scanner route.Uri.parse(SetupUrl)overtoUri()per the spec's idiom preference.try/catchforActivityNotFoundException— explicitly deferred per ticket's Out of Scope section ([[Evidence-Based Fix Selection]]).🤖 Generated with Claude Code