Skip to content

re-up formatting [2026-04-19]#449

Merged
jGaboardi merged 5 commits into
pysal:mainfrom
jGaboardi:lint-format-turn-on-pre-commit
Apr 20, 2026
Merged

re-up formatting [2026-04-19]#449
jGaboardi merged 5 commits into
pysal:mainfrom
jGaboardi:lint-format-turn-on-pre-commit

Conversation

@jGaboardi

@jGaboardi jGaboardi commented Apr 19, 2026

Copy link
Copy Markdown
Member

re-up formatting

  • formats esda/* & docs/*
  • PR 1 of re-up formatting & linting + turn on pre-commit for PRs

👀 👀 👀

Even with only formatting there already a very large diff. Would we like this formatting+linting reup to be done incrementally in:

  • 1 PR
  • Across PRs

@pysal/steering

@jGaboardi jGaboardi self-assigned this Apr 19, 2026
@codecov

codecov Bot commented Apr 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.2%. Comparing base (a743d21) to head (01fdb8f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
esda/shape.py 81.8% 4 Missing ⚠️
esda/significance.py 92.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #449   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files         27      27           
  Lines       3969    3969           
=====================================
  Hits        3264    3264           
  Misses       705     705           
Files with missing lines Coverage Δ
esda/__init__.py 100.0% <100.0%> (ø)
esda/crand.py 93.7% <100.0%> (ø)
esda/moran_local_mv.py 97.3% <100.0%> (ø)
esda/significance.py 94.1% <92.3%> (ø)
esda/shape.py 73.6% <81.8%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi

Copy link
Copy Markdown
Member Author

Maybe this PR only for formatting and a follow up the does linting + turn pre-commit on?

@jGaboardi jGaboardi changed the title [WIP] re-up formatting & linting + turn on pre-commit for PRs re-up formatting [2026-04-19] Apr 19, 2026
@jGaboardi jGaboardi marked this pull request as ready for review April 19, 2026 19:12
Comment thread esda/tests/test_shape.py
Comment thread esda/tests/test_shape.py
Comment thread esda/tests/test_shape.py
@jGaboardi jGaboardi requested a review from martinfleis April 20, 2026 14:02
@jGaboardi jGaboardi merged commit cdb8076 into pysal:main Apr 20, 2026
17 checks passed
@jGaboardi jGaboardi deleted the lint-format-turn-on-pre-commit branch April 20, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants