Skip to content

Stricter linting following #451#452

Merged
sjsrey merged 4 commits into
pysal:mainfrom
jGaboardi:stricter_linting
Apr 26, 2026
Merged

Stricter linting following #451#452
sjsrey merged 4 commits into
pysal:mainfrom
jGaboardi:stricter_linting

Conversation

@jGaboardi

Copy link
Copy Markdown
Member

@jGaboardi jGaboardi self-assigned this Apr 26, 2026
@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.3%. Comparing base (182d9f4) to head (630a4ee).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
esda/silhouettes.py 40.0% 3 Missing ⚠️
esda/crand.py 60.0% 2 Missing ⚠️
esda/topo.py 0.0% 2 Missing ⚠️
esda/mixture_smoothing.py 91.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #452   +/-   ##
=====================================
  Coverage   82.2%   82.3%           
=====================================
  Files         27      27           
  Lines       3965    3961    -4     
=====================================
- Hits        3260    3258    -2     
+ Misses       705     703    -2     
Files with missing lines Coverage Δ
esda/__init__.py 100.0% <100.0%> (ø)
esda/adbscan.py 93.4% <100.0%> (ø)
esda/geary_local.py 87.0% <100.0%> (ø)
esda/geary_local_mv.py 98.9% <100.0%> (ø)
esda/getisord.py 70.6% <100.0%> (ø)
esda/join_counts.py 97.4% <100.0%> (ø)
esda/join_counts_local.py 98.2% <100.0%> (ø)
esda/join_counts_local_bv.py 98.8% <100.0%> (ø)
esda/join_counts_local_mv.py 98.2% <100.0%> (ø)
esda/lee.py 80.0% <100.0%> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjsrey sjsrey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this could be redirected against sjsrey:docs?
There are a lot of nb changes there that may lead to conflicts later on if we merge this into main, and then merge that?

@jGaboardi

jGaboardi commented Apr 26, 2026

Copy link
Copy Markdown
Member Author

Any chance this could be redirected against sjsrey:docs? There are a lot of nb changes there that may lead to conflicts later on if we merge this into main, and then merge that?

I already massaged the PR from yesterday into sjsrey:docs after we merged (40a22f6) - so I was planning on doing the same for this PR after merging, which would be the same result as you suggest.

@sjsrey sjsrey merged commit 320a005 into pysal:main Apr 26, 2026
18 checks passed
@jGaboardi jGaboardi deleted the stricter_linting branch April 26, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants