mark by_col() methods as deprecated#456
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (16.7%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
- Coverage 82.3% 82.1% -0.2%
=======================================
Files 27 27
Lines 3961 3973 +12
=======================================
+ Hits 3258 3260 +2
- Misses 703 713 +10
🚀 New features to boost your workflow:
|
Member
Author
|
@sjsrey -- since this is simply marking the |
martinfleis
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mark
by_col()methods as deprecatedsee #305
by_col()methods inmoran.pyby_col()methods in other modules & classes? -- xrefMoran*.by_col()methods deprecated? #305 (comment)