Skip to content

mark by_col() methods as deprecated#456

Merged
jGaboardi merged 1 commit into
pysal:mainfrom
jGaboardi:GH305_deprecate_by_col
Apr 27, 2026
Merged

mark by_col() methods as deprecated#456
jGaboardi merged 1 commit into
pysal:mainfrom
jGaboardi:GH305_deprecate_by_col

Conversation

@jGaboardi

Copy link
Copy Markdown
Member

mark by_col() methods as deprecated

see #305

the tests for the Moran*.by_col() methods have been deprecated and marked for removal "in the next release" (though that seems to have been ≈4 years ago), but is no actual indication the methods themselves are marked as such. For example, Moran_Tester.test_by_col() is marked deprecated, but there is nothing mentioning that in Moran.by_col()


@jGaboardi jGaboardi self-assigned this Apr 26, 2026
@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.1%. Comparing base (320a005) to head (9f0fa94).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
esda/moran.py 16.7% 10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (16.7%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #456     +/-   ##
=======================================
- Coverage   82.3%   82.1%   -0.2%     
=======================================
  Files         27      27             
  Lines       3961    3973     +12     
=======================================
+ Hits        3258    3260      +2     
- Misses       703     713     +10     
Files with missing lines Coverage Δ
esda/moran.py 83.6% <16.7%> (-1.3%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi requested a review from sjsrey April 26, 2026 22:08
@jGaboardi

Copy link
Copy Markdown
Member Author

@sjsrey -- since this is simply marking the by_col() methods in Moran with a future removal warning, shall we go ahead merge. Nothing is being removed here.

@jGaboardi jGaboardi merged commit f605ab5 into pysal:main Apr 27, 2026
31 of 33 checks passed
@jGaboardi jGaboardi deleted the GH305_deprecate_by_col branch April 27, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants