Debugging broken search on esda docs

[sjsrey]

This will get search to work, however, it is unique to esda which feels fragile to me.

[jGaboardi]

Do we know what is making esda a special case for this?

[knaaptime]

this is weird! its on the javascript side, so its clearly the theme/its interaction with sphinx

maybe there is an esda dependency thats forcing an older version of the theme or something? its odd we're not seeing this in, e.g. tobler or lib (nor the alpha package i'm working on separately)

[martinfleis]

I really don't like this solution.

[jGaboardi]

I really don't like this solution.

The only way this comment could have been more Martin-esque is if "solution" was in quotes.

[sjsrey]

Just to be clear, this is intended more as a debugging record rather than a real fix. I will be focusing on the docs in upcoming sprints.

ref: #459

[martinfleis]

It is an upstream bug that has been reported - jbms/sphinx-immaterial#485. We shall temporarily pin sphinx to <9, which is what I have in gwlearn, and what we coincidentally get in libpysal without a pin.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.8%. Comparing base (8c05bdb) to head (aab619c).

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #488   +/-   ##
=====================================
  Coverage   85.8%   85.8%           
=====================================
  Files         27      27           
  Lines       3625    3625           
=====================================
  Hits        3112    3112           
  Misses       513     513           

Files with missing lines	Coverage Δ
esda/getisord.py	88.0% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knaaptime]

i thought the pin was <9?

[jGaboardi]

Are we OK with the errors for now?

https://github.com/pysal/esda/actions/runs/25570840856/job/75065855524?pr=488#step:5:628

[jGaboardi]

I'm not sure this did the trick. Still nothing happens when attempting to search. Nothing clickable and no results.

[martinfleis]

Of course... the pin needs to show up in the Conda environment, not just in pyproject.