Skip to content

GHA release template#32

Merged
jGaboardi merged 14 commits intopysal:mainfrom
jGaboardi:gha_release
Dec 2, 2022
Merged

GHA release template#32
jGaboardi merged 14 commits intopysal:mainfrom
jGaboardi:gha_release

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jul 6, 2020 •
edited
Loading

This PR

  • adds the template for automated tagged releases + PyPI publishing through GitHub Actions
  • adds clarifying instructions for unittests.yml
  • Resolves Add GHA for package upload #29

@jGaboardi jGaboardi requested review from knaaptime and sjsrey July 6, 2020 14:03
@jGaboardi jGaboardi self-assigned this Jul 6, 2020
knaaptime
knaaptime approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@knaaptime knaaptime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I also think a boilerplate readme with some common formatting, thats templated out for PACKAGENAME or something w/ content designed to be replaced would be useful in here. That way we could package up some dev instructions as well in a place thats a bit more visible than the wiki. I can take a crack that that

@jGaboardi jGaboardi mentioned this pull request Jul 7, 2020
Closed
@knaaptime
Copy link
Member

knaaptime commented Jul 7, 2020

gitcount notebook also needs to be updated here

@jGaboardi
Copy link
Member Author

jGaboardi commented Jul 7, 2020

gitcount notebook also needs to be updated here

nice catch.

see also pysal/libpysal#316 (comment)

@jGaboardi jGaboardi requested a review from knaaptime July 14, 2020 00:01
@jGaboardi
Copy link
Member Author

jGaboardi commented Jul 14, 2020

a boilerplate readme with some common formatting, thats templated out for PACKAGENAME or something w/ content designed to be replaced would be useful in here

Would you like to tack that on to this PR or in another?

@jGaboardi jGaboardi mentioned this pull request Jan 13, 2021
Closed
@jGaboardi jGaboardi added the WIP label Jan 14, 2021
@jGaboardi jGaboardi changed the title GHA release template [WIP] GHA release template Jan 14, 2021
@jGaboardi
Copy link
Member Author

jGaboardi commented Jan 14, 2021 •
edited
Loading

TO DO

  • move Makefile from docsrc/ to docs
  • remove docsrc
  • remove readthedocs.yml
  • add README.md template

@jGaboardi
Copy link
Member Author

jGaboardi commented Jan 14, 2021

@knaaptime I think this is ready for re-review.

@jGaboardi jGaboardi removed the WIP label Jan 14, 2021
@jGaboardi jGaboardi changed the title [WIP] GHA release template GHA release template Jan 14, 2021
@knaaptime
Copy link
Member

knaaptime commented Dec 1, 2022

lets merge this. Do we need to add the latest and greatest @jGaboardi ?

@knaaptime knaaptime mentioned this pull request Dec 1, 2022
Closed
knaaptime
knaaptime reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@knaaptime knaaptime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do we want to keep the existing giddy docs or generalize them a little bit?
  2. lets clean out the docs/generated folde

@jGaboardi
Copy link
Member Author

jGaboardi commented Dec 1, 2022

Completely forgot about this... Yeah, maybe let go ahead and merge, then we can update later.

@jGaboardi jGaboardi merged commit a5b711f into pysal:main Dec 2, 2022
@jGaboardi jGaboardi deleted the gha_release branch December 2, 2022 14:31
This was referenced Dec 2, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knaaptime knaaptime knaaptime approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

Assignees

@jGaboardi jGaboardi

Labels

automation GitHub Actions release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add GHA for package upload

2 participants

@jGaboardi @knaaptime