Skip to content

Conversation

@jGaboardi
Copy link
Member

This PR:

  • starts with:
    • ruff format of the tobler/ and notebooks/ directories
    • couple updates/clean-up to pyproject.toml
  • if this looks good and is desired I'd like to:
    • ruff check the repo for linting (there are at least 70 rules violations when run locally just now)
    • add pre-commit1
  • I can do the linting in a follow-up PR or this one.

Footnotes

  1. I know pre-commit is not the bee's knees for everybody, so no sweat if that's not desired

@jGaboardi jGaboardi added the maint label Oct 9, 2025
@jGaboardi jGaboardi self-assigned this Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.2%. Comparing base (b35f150) to head (07d757c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #230   +/-   ##
=====================================
  Coverage   88.2%   88.2%           
=====================================
  Files         14      14           
  Lines        534     534           
=====================================
  Hits         471     471           
  Misses        63      63           
Files with missing lines Coverage Δ
tobler/__init__.py 100.0% <ø> (ø)
tobler/area_weighted/area_interpolate_dask.py 81.1% <100.0%> (ø)
tobler/dasymetric/__init__.py 100.0% <100.0%> (ø)
tobler/dasymetric/masked_area_interpolate.py 88.2% <100.0%> (ø)
tobler/model/__init__.py 100.0% <100.0%> (ø)
tobler/pycno/__init__.py 100.0% <100.0%> (ø)
tobler/pycno/pycno.py 82.8% <100.0%> (ø)
tobler/util/__init__.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knaaptime
Copy link
Member

adding pre commit is fine with me. Anything else you want to add before merge?

@jGaboardi
Copy link
Member Author

adding pre commit is fine with me. Anything else you want to add before merge?

Let's get this merged and then I'll start with actual linting in a follow-up.

@knaaptime knaaptime merged commit 7d87291 into pysal:main Oct 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants