-
Notifications
You must be signed in to change notification settings - Fork 7
MAINT: pysat 3.0 release, Github Actions #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [3.8, 3.9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just do the flake8 test on one python version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main thought here is that it doesn't matter. Flake8 is now decoupled from the tests. It is currently set up so that if flake8 fails, the tests stop. The upside to this is that you don't have to wait for an hour to see you have a style error.
Long-term, I imagine adding a second workflow that only runs once for the documentation checks. We could potentially move the flake8 check there to fully decouple from the multi-environment tests.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
rstoneback
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jklenzing. Approving my part, not getting ahead of @aburrell's comments.
|
Thanks @rstoneback. Going to leave this here for discussion on Friday |
Uh oh!
There was an error while loading. Please reload this page.