Skip to content

Conversation

@jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 5, 2021

  • Updates the CI environment to use Github Actions rather than Travis CI
  • Installs pysat 3.0 directly from pypi
  • Uses flake8 rather than pytest-flake8 for immediate feedback if a style error is present

@jklenzing jklenzing marked this pull request as ready for review April 5, 2021 22:43
@jklenzing
Copy link
Member Author

Verified that flake8 migration works as expected. Tagging all of you for discussion at the meeting this week. This pull should be a clean replacement to #48 and #45.

strategy:
fail-fast: false
matrix:
python-version: [3.8, 3.9]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just do the flake8 test on one python version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main thought here is that it doesn't matter. Flake8 is now decoupled from the tests. It is currently set up so that if flake8 fails, the tests stop. The upside to this is that you don't have to wait for an hour to see you have a style error.

Long-term, I imagine adding a second workflow that only runs once for the documentation checks. We could potentially move the flake8 check there to fully decouple from the multi-environment tests.

Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
jklenzing and others added 2 commits April 6, 2021 16:33
Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jklenzing. Approving my part, not getting ahead of @aburrell's comments.

@jklenzing
Copy link
Member Author

Thanks @rstoneback. Going to leave this here for discussion on Friday

@jklenzing jklenzing merged commit 5f11a9a into develop Apr 8, 2021
@jklenzing jklenzing deleted the maint/py30ga branch April 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants