PythonVersions.pas - improved PythonVersionFromPath with a new parameter FindLatestVersion

[idanmiara]

I've implemented this feature it as you suggested.

[pyscripter]

PythonVersionFromPath was meant to be used with the home path of python. So it checks whether python.exe exists in the same folder as the python??.dll. In QGIS is python.exe located in the same folder as the dll? And if there more than one dll's are located in the bin folder to which version python.exe corresponds to?

  // check if same platform
  try
    if {$IFDEF CPUX64}not {$ENDIF}IsEXEx64(DLLPath+'\python.exe') then Exit;
  except
    Exit;
  end;

[idanmiara]

hmm.. I didn't notice that test before. QGIS put the following along with the python dlls in the bin folder: python.exe (for python27.dll); python3.exe (for python36.dll) The libraries are located in separate folders under apps. They don't mix architectures, so technically it would work because all of these would be either x86 or x64 so checking python.exe would be sufficient. We could check the dll architecture instead of the exe but it seems more complicated: https://stackoverflow.com/questions/971689/win32-api-to-tell-whether-a-given-binary-exe-or-dll-is-x86-x64-or-ia64 https://stackoverflow.com/questions/495244/how-can-i-test-a-windows-dll-file-to-determine-if-it-is-32-bit-or-64-bit I don't see a justification for that.

…

On Mon, 15 Oct 2018 at 14:34, pyscripter ***@***.***> wrote: PythonVersionFromPath was meant to be used with the home path of python. So it checks whether python.exe exists in the same folder as the python??.dll. In QGIS is python.exe located in the same folder as the dll? And if there more than one dll's are located in the bin folder to which version python.exe corresponds to? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZIQrXEIB84a5DLDC_sCORfriifOo7L6ks5ulHKwgaJpZM4XcGZ4> .

[pyscripter]

As mentioned above PythonVersionFromPath was meant to be used with the home path of python and not with another path that just contains dlls and exes. Other PythonVersions functionality will not work (is_venv, is_virtualenv etc.). Also, your version PythonVersionFromPath is much slower than the original, since it uses FileExist for all possible python??.dll.

QGIS folder setup is a special case that you can accomodate in your own code.