Regular package #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core serial module exports names, such as serial_for_url, which interferes with the Python's namespace package mechanism. Unfortunately, this means we can't use namespace packages without severely breaking compatibility with existing pyserial clients. We need to take an alternative approach of making pyserial-asyncio provide its functionality as a regular package alongside pyserial. I've followed a common convention of naming the package pyserial_asyncio.
This allows tests to be run with python -m test.test_asyncio <port> without running into conflicts with Python's built-in unit tests which also have a test.test_asyncio with runs the Python Standard Library tests.
This allows tests to be run with python -m test.test_asyncio <port> without running into conflicts with Python's built-in unit tests which also have a test.test_asyncio with runs the Python Standard Library tests.
…ge) naming confusion.
Collaborator
Author
|
Note that the Travis build still fails, but now with a serial timeout error rather than an import error, so progress of a sort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like namespace packages are going to work with pySerial. :-(
This is because pySerial exports names from its root package
serial.__init__.pywhich is not permitted in namespace packages.This change simply makes the
pyserial-asynciodistribution into a separate, regular package which depends onpyserial. It uses a distinct top-level package name ofserial_asynciofollowing a broadly used convention for extension package naming.I'll put together a companion pull request for core
pyserialto remove the namespace packaging from there too.