Conversation
|
Seems like you missed the most recent bugfixes, merge them into your fork please. |
|
can confirm working tho |
ani-cli
Outdated
| ep_choice_start=$((episode + 1)) | ||
| ep_choice_end="" | ||
| ;; | ||
| b) |
There was a problem hiding this comment.
try using tabs here to maintain uniform indent
There was a problem hiding this comment.
I was using tabs before the new commit
ani-cli
Outdated
| menu_line_alternate "replay current episode" "r" | ||
| menu_line_alternate "search for another anime" "a" | ||
| menu_line_alternate "search history" "h" | ||
| menu_line_alternate "select quality" "b" |
There was a problem hiding this comment.
menu_line_alternate "select quality (current: $quality)" "b"to let the user know what the current quality is
| prompt "Select quality" | ||
| quality="$REPLY" | ||
| video_url=$(get_video_quality "$dpage_link") | ||
| ;; |
There was a problem hiding this comment.
Also why not just set quality
just this here works
b)
prompt "Select quality"
quality="$REPLY"
;;
```IThere was a problem hiding this comment.
what the point of fetching video_url? we are anyways fetching it open_episode, the current approach does a redundant part which slows the script
There was a problem hiding this comment.
Okay, will remove that part
RaynardGerraldo
added
category: ui ux
4 participants
No description provided.