Reset marker config during unconfigure#868
Merged
tobiasraabe merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
02dd633 to
dccf1f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset the global marker generator configuration when pytask unconfigures so process-local strict marker settings cannot affect later marker access.
Root Cause
pytask_parse_config()stores the active config on the singletonMARK_GEN. A run using--strict-markersleft that config attached afterpytask_unconfigure(), so later code in the same process could treat unknown markers as strict errors instead of warning.Changes
pytask_unconfigure()hook that clearsMARK_GEN.config.pytask.mark.CHANGELOG.md.Validation
uv run --group test pytest tests/test_mark.py::test_error_with_unknown_marker_and_strict tests/test_mark_structures.py::test_aliases tests/test_mark.py::test_strict_markers_do_not_leak_after_unconfigure -q