Skip to content

Update hatchling version requirement in pyproject.toml #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2025
+14 −3
Merged

Update hatchling version requirement in pyproject.toml #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8e35f
Update hatchling version requirement in pyproject.toml
sebastianelsner Nov 10, 2025
b601832
Update CHANGELOG for version 2.1.2
sebastianelsner Nov 10, 2025
51e39da
Add package check with twine
nicoddemus Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,13 @@ jobs:
with:
python-version: ${{ matrix.python }}

- name: Install tox
run: pip install tox
- name: Install dependencies
run: pip install tox twine

- name: Check package
shell: bash
run: |
twine check --strict dist/*

- name: Test
shell: bash
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2.1.2 (2025-11-10)
------------------

* `#376 <https://github.com/pytest-dev/execnet/issues/376>`__ fix artifact building - pin minimal version of hatch


2.1.1 (2024-04-08)
------------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = [
"hatchling",
"hatchling>=1.26",
Copy link
Member

@nicoddemus nicoddemus Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test that the original issue was fixed in CI?

Perhaps running pip check on the installed environment?

Copy link
Contributor Author

@sebastianelsner sebastianelsner Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using twine we can do:

twine check --strict dist/*

With the old hatchling this gived:

twine check --strict dist/* 
Checking dist/execnet-2.1.2.dev116+gb6018320f-py3-none-any.whl: ERROR    InvalidDistribution: Invalid distribution metadata: license-expression introduced in metadata version 2.4, not 2.3

And does not error with the new one.

But I think twine is not used in this project right now. So we add a dependency and it needs to be added in the release process and I do not know where.

Copy link
Member

@nicoddemus nicoddemus Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using twine we can do:

Thanks, I updated test.yml to use this check, it should be working now.

Copy link
Contributor Author

@sebastianelsner sebastianelsner Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good!

"hatch-vcs",
]
build-backend = "hatchling.build"
Expand Down
Loading