Skip to content

Cucumber json formatter #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Jul 27, 2014
Merged

Cucumber json formatter #46

merged 61 commits into from
Jul 27, 2014

Conversation

@albertjan
Copy link
Contributor

@albertjan albertjan commented May 11, 2014

No description provided.

bubenkoff and others added 30 commits April 9, 2014 00:40
@bubenkoff
start implementing cucumber json
3b60a9e
@bubenkoff
implementing cucumber json in progress
b9a9634
correct func name
c9b509a
@bubenkoff
fix test
c22464f
update gitignore for pycharm
961b724
@bubenkoff
store item in the report
fd16428
Merge branch 'cucumber-json-formatter' of https://github.com/paylogic…
3d10266 
…/pytest-bdd into cucumber-json-formatter
@bubenkoff
add scenario
9f6ce33
Merge branch 'cucumber-json-formatter' of https://github.com/albertja…
c7cd4ee 
…n/pytest-bdd into cucumber-json-formatter
@bubenkoff
correct scenario saving
bc2c347
@bubenkoff
Merge branch 'cucumber-json-formatter' of github.com:albertjan/pytest…
9dbb638 
…-bdd into cucumber-json-formatter
@bubenkoff
scenario attrs
5935411
use tests var
375729b
Just get the status
fe56114
map each step
870c69f
cast reprcrash to string skip if there are no steps
70472f3
@bubenkoff
equals_any added
127cba2
@bubenkoff
add feature line number
a9ca6db
add feature hash
1f62168
adds description
052e74e
rename tests to features
c2dd06f
@bubenkoff
correct expectation
aa81fea
@bubenkoff
Merge branch 'cucumber-json-formatter' of github.com:albertjan/pytest…
cb6db6f 
…-bdd into cucumber-json-formatter
change name of scenario
fe49943
Merge branch 'cucumber-json-formatter' of https://github.com/albertja…
50d2bd7 
…n/pytest-bdd into cucumber-json-formatter
makes the keyword nice
504d722
@bubenkoff
correct expectation
164ac9c
corrects the reference
faa5ece
corrects the reference
9c19653
Merge branch 'cucumber-json-formatter' of https://github.com/albertja…
29249b6 
…n/pytest-bdd into cucumber-json-formatter
@bubenkoff
Copy link
Member

bubenkoff commented May 11, 2014

@olegpidsadnyi please review

olegpidsadnyi
olegpidsadnyi reviewed May 11, 2014
View reviewed changes
pytest_bdd/feature.py Outdated
Copy link
Contributor

@olegpidsadnyi olegpidsadnyi May 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think line_number is not optional?

@olegpidsadnyi
Copy link
Contributor

olegpidsadnyi commented May 11, 2014

What about failing tests?

@bubenkoff
Copy link
Member

bubenkoff commented May 12, 2014

will check

On 11 May 2014 22:33, Oleg Pidsadnyi notifications@github.com wrote:

What about failing tests?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/46#issuecomment-42782293
.

Anatoly Bubenkov

@coveralls
Copy link

coveralls commented Jul 24, 2014

Coverage Status

Coverage decreased (-6.13%) when pulling a427de3 on albertjan:cucumber-json-formatter into eeae212 on olegpidsadnyi:master.

@coveralls
Copy link

coveralls commented Jul 24, 2014

Coverage Status

Coverage decreased (-6.13%) when pulling a427de3 on albertjan:cucumber-json-formatter into eeae212 on olegpidsadnyi:master.

@coveralls
Copy link

coveralls commented Jul 24, 2014

Coverage Status

Changes Unknown when pulling fde61f7 on albertjan:cucumber-json-formatter into * on olegpidsadnyi:master*.

@bubenkoff bubenkoff mentioned this pull request Jul 24, 2014
Open
@coveralls
Copy link

coveralls commented Jul 25, 2014

Coverage Status

Changes Unknown when pulling 76be972 on albertjan:cucumber-json-formatter into * on olegpidsadnyi:master*.

@coveralls
Copy link

coveralls commented Jul 26, 2014

Coverage Status

Coverage decreased (-6.04%) when pulling 6e80100 on albertjan:cucumber-json-formatter into 7df81d9 on olegpidsadnyi:master.

olegpidsadnyi pushed a commit that referenced this pull request Jul 27, 2014
Merge pull request #46 from albertjan/cucumber-json-formatter
ffe906b 
Cucumber json formatter
@olegpidsadnyi olegpidsadnyi merged commit ffe906b into pytest-dev:master Jul 27, 2014
@albertjan
Copy link
Contributor Author

albertjan commented Jul 27, 2014

@bubenkoff @olegpidsadnyi awesome this landed. 😄 still took some work I see.

@bubenkoff
Copy link
Member

bubenkoff commented Jul 27, 2014

a lot of work, but done :)

On 27 July 2014 13:58, Albert-Jan Nijburg notifications@github.com wrote:

@bubenkoff https://github.com/bubenkoff @olegpidsadnyi
https://github.com/olegpidsadnyi awesome this landed. [image: 😄]
still took some work I see.

—
Reply to this email directly or view it on GitHub
#46 (comment)
.

Anatoly Bubenkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albertjan @dimazest @bubenkoff @olegpidsadnyi @coveralls