C++ tests not collected due to '*_test' mask on Windows

[1fabrism]

Hello, I am a beginner so I probably just misunderstood how to use this package, however it seems that my installation has trouble collecting tests from C++ files. Here's my situation:

• I have both pytest and pytest-cpp installed (both through pip).
• I have a folder containing:
  'generator_demo_test.py' that has two test functions, each with its own assert statement
  'generator_demo_test.cpp' that #includes gtest.h and has two TEST() functions (but no main() function, if that makes a difference)

I compiled the cpp file with gtest and now have demo_test.exe in the folder with the .py and .cpp files. Then I open a terminal in that folder and type py.test --collect-only and I get the following output:

=============test session starts =============
platform win32 -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: C:\Users\myuser\Documents\Code\10_Local\demo
plugins: allure-pytest-2.8.10, cpp-1.2.0, TyphoonTest-1.11.1
collected 2 items
<Module generator_demo_test.py>
  <Function test_vout>
  <Function test_samples>
=============no tests ran in 0.14s ==========

So the c++ tests are ignored.

However, if I type py.test --collect-only generator_demo_test.exe, then the output is:

================================================= test session starts =================================================
platform win32 -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: C:\Users\myuser\Documents\Code\10_Local\demo
plugins: allure-pytest-2.8.10, cpp-1.2.0, TyphoonTest-1.11.1
collected 2 items
<CppFile oldgenerator_demo_test.exe>
  <CppItem Addition_TEST_SUITE.AdderTest_SIMPLE>
  <CppItem Addition_TEST_SUITE.AdderTest_COMPLEX>

================================================== warnings summary ===================================================
c:\users\myuser\appdata\local\programs\python\python37\lib\site-packages\pytest_cpp\plugin.py:41
  c:\users\myuser\appdata\local\programs\python\python37\lib\site-packages\pytest_cpp\plugin.py:41: PytestDeprecationWarning: direct construction of CppFile has been deprecated, please use CppFile.from_parent
    return CppFile(path, parent, facade_class(), test_args)

c:\users\myuser\appdata\local\programs\python\python37\lib\site-packages\pytest_cpp\plugin.py:67
c:\users\myuser\appdata\local\programs\python\python37\lib\site-packages\pytest_cpp\plugin.py:67
  c:\users\myuser\appdata\local\programs\python\python37\lib\site-packages\pytest_cpp\plugin.py:67: PytestDeprecationWarning: direct construction of CppItem has been deprecated, please use CppItem.from_parent
    yield CppItem(test_id, self, self.facade, self._arguments)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================= 3 warnings in 0.11s =================================================

Then it does find the C++ stuff. (Also, any ideas about those warnings?)

So I am not sure how to make it collect both py tests and c++ tests just by running py.test. As a disclaimer, I did not configure anything after installing pytest-cpp with pip. I saw about the cpp_files setting in the ReadMe but it is not clear to me where that configuration file is, and besides it says the default is already *_test executables.

[nicoddemus]

Hi @1fabrism!

Hmmm weird. It should be able to run normal python test files alongside C++ test files without a problem.

You have both generator_demo_test.py and generator_demo_test.exe in the same directory, perhaps that might be the problem? Can you rename generator_demo_test.exe to something else (say my_demo_test.exe) and see if that makes a difference?

Also, any ideas about those warnings?

You can ignore those, I need to make a new pytest-cpp release to make it compatible with pytest>=5.4. 👍

[1fabrism]

Hi @nicoddemus, thanks for the help!

I tried renaming generator_demo_test.exe to my_generator_demo.exe but it made no difference. I also tried moving the .exe file to a child folder but that made no difference either.
What did make a difference was renaming the exe to test_demo.exe. After doing that and running again py.test --collect-only it found everything, even with the .exe file still inside the child folder:

collected 4 items
<Module generator_demo_test.py>
  <Function test_vout>
  <Function test_samples>
<CppFile captured_signals/test_demo.exe>
  <CppItem Addition_TEST_SUITE.AdderTest_SIMPLE>
  <CppItem Addition_TEST_SUITE.AdderTest_COMPLEX>

So I guess there is somewhere a setting for what pytest-cpp is looking for (indeed as mentioned in the ReadMe), however I'm still not sure where that file is...

[nicoddemus]

Ahh OK I see what's happening.

The default masks are test_* and *_test.

*_test won't match generator_demo_test.exe on Windows because of the .exe extension, but test_* will, because * will match the extension.

On Windows we probably should add .exe explicitly to the masks here:

pytest-cpp/pytest_cpp/plugin.py

Lines 34 to 36 in 407df50

	for pat in masks:
	if path.fnmatch(pat):
	break

I will update the description.

Thanks for finding and reporting this!

[nicoddemus]

1.2.1 released with this fix. 👍