Skip to content

#39 cpp_ignore_py_files option#42

Closed
fj128 wants to merge 2 commits intopytest-dev:masterfrom
fj128:master
Closed

#39 cpp_ignore_py_files option#42
fj128 wants to merge 2 commits intopytest-dev:masterfrom
fj128:master

Conversation

@fj128
Copy link
Copy Markdown
Contributor

@fj128 fj128 commented Nov 15, 2019

This adds a new option, "cpp_ignore_py_files", that is True by default, and prevents the plugin from trying to execute ordinary pytest modules that are marked as executable, to see if they are secretly boost or google test modules. Implements #39

@nicoddemus
Copy link
Copy Markdown
Member

Thanks @fj128!

The change looks good, I will have to take a look at why CI is failing though.

@fj128
Copy link
Copy Markdown
Contributor Author

fj128 commented Nov 21, 2019 via email

@nicoddemus
Copy link
Copy Markdown
Member

Superseded by #44.

I've fixed the tests and CI on master, so I've opened #44 with your commit adding the option. Let's continue the review in there. 👍

@nicoddemus nicoddemus closed this Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants