#39 cpp_ignore_py_files option#42
Closed
fj128 wants to merge 2 commits intopytest-dev:masterfrom
Closed
Conversation
Member
|
Thanks @fj128! The change looks good, I will have to take a look at why CI is failing though. |
Contributor
Author
|
Because scons is no longer installed by default apparently, so nothing at
all works. My apologies, I actually missed some parts of tox.ini and
thought that it was never expected to work in the first place. If you point
me at some explanation of how to iterate attempts to fix this without
spamming the pull request then I could do it myself, it would be
even better since I also kinda remember what to fix in the tests failing
because of boost::test changes.
…On Thu, Nov 21, 2019 at 1:08 PM Bruno Oliveira ***@***.***> wrote:
Thanks @fj128 <https://github.com/fj128>!
The change looks good, I will have to take a look at why CI is failing
though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=AACLHDZSKPVLCZ5VFMIF5N3QUZT3PA5CNFSM4JOAJONKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZ3HDQ#issuecomment-557036430>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACLHD7L4CDT2NY7W4BSRT3QUZT3PANCNFSM4JOAJONA>
.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new option, "cpp_ignore_py_files", that is True by default, and prevents the plugin from trying to execute ordinary pytest modules that are marked as executable, to see if they are secretly boost or google test modules. Implements #39