Skip to content

admin_user - get user by natural key #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2020
Merged

admin_user - get user by natural key #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
387946d
admin_user - get user by natural key
olzhasar Oct 9, 2020
776b0b2
Update pytest_django/fixtures.py
olzhasar Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pytest_django/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,11 @@ def admin_user(db, django_user_model, django_username_field):
username = "admin@example.com" if username_field == "email" else "admin"

try:
user = UserModel._default_manager.get(**{username_field: username})
# The default behavior of `get_by_natural_key()` is to look up by `username_field`.
# However the user model is free to override it with any sort of custom behavior.
# The Django authentication backend already assumes the lookup is by username,
# so we can assume so as well.
user = UserModel._default_manager.get_by_natural_key(username)
except UserModel.DoesNotExist:
extra_fields = {}
if username_field not in ("username", "email"):
Expand Down