update supported python and pytest versions #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youtux
requested changes
Dec 23, 2020
Contributor
youtux
left a comment
youtux
left a comment
There was a problem hiding this comment.
Also please add one (or more) entries to the CHANGES.rst saying which pythons and pytest we started and stopped supporting.
tox.ini
Outdated
| envlist = py27-pytest{43,44,45,46}, | ||
| py38-pytest{43,44,45,46,50,51,52,53,54,60,latest}, | ||
| envlist = py27-pytest46, | ||
| py38-pytest{46,54,60,61,62,latest,master}, |
Contributor
There was a problem hiding this comment.
I would prefer to keep on testing all the minor versions of pytest that we claim to support (5.0, 5.1, 5.2, 5.3).
| language: python | ||
| dist: bionic | ||
| python: | ||
| - "2.7" |
Contributor
There was a problem hiding this comment.
We can remove python2.7 compatibility. Make sure to update the python_requires marker accordingly in the setup.py.
Contributor
Author
There was a problem hiding this comment.
We can make it in #105 (it just needs some small polishing) after merging this one. What do you think?
Member
|
here's a PR with pyupgrade: https://github.com/pytest-dev/pytest-factoryboy/pull/105/files |
Contributor
|
Thank you for the PR! |
skarzi
deleted the
feature/update-supported-python-and-pytest-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
setup.pyand run tests)pytestversions supported bypytest-factoryboywith these officially maintained bypytest-devteam (I get versions from branch list ofpytestrepo)pep8maxlinelengthpytest's ini optionWhat do you think about dropping support for python 2?
This change is