drop support for EOL python 2 #105

graingert · 2020-12-23T10:31:20Z

see also #104 (comment)

This change is

setup.py

.travis.yml

pyproject.toml

pytest_factoryboy/fixture.py

setup.py

tox.ini

skarzi · 2020-12-23T13:39:33Z

@graingert could you merge master? or (if it's easier) run pyupgrade on master again?

skarzi · 2020-12-23T14:55:47Z

Let's apply black on setup.py file - https://travis-ci.org/github/pytest-dev/pytest-factoryboy/jobs/751201487#L697

youtux · 2020-12-23T15:18:13Z

setup.cfg

+    Topic :: Software Development :: Libraries
+    Topic :: Utilities
+    Programming Language :: Python :: 3
+    Programming Language :: Python :: 3 :: Only


I wouldn't use this classifier, as it implies that the project would not be compatible with a hypothetical python 4

this is to match pytest's config: https://github.com/pytest-dev/pytest/blob/master/setup.cfg#L19

Why do we have to match pytest's config?

As far as we know, it's not compatible with Python 4...

I disagree with this, if we follow this logic then we should also add python_requires<4, and we don't do that.
Python 4 will probably not introduce incompatible changes like python 3 did.

Please remove this classifier.

tox.ini

pyproject.toml

youtux · 2020-12-23T16:23:16Z

setup.cfg

+    Topic :: Software Development :: Libraries
+    Topic :: Utilities
+    Programming Language :: Python :: 3
+    Programming Language :: Python :: 3 :: Only


I disagree with this, if we follow this logic then we should also add python_requires<4, and we don't do that.
Python 4 will probably not introduce incompatible changes like python 3 did.

pytest_factoryboy/fixture.py

.travis.yml

hugovk

Looks good! Presence or absence of the 3 :: Only classifier isn't a big deal, would be good to add it 3.9 as well.

graingert · 2020-12-23T17:03:25Z

@hugovk 3.9 classifier is already present

hugovk · 2020-12-23T17:28:11Z

👍

And add 3.9 to CI?

skarzi · 2020-12-23T17:31:22Z

pytest_factoryboy/__init__.py

+from .fixture import LazyFixture
+from .fixture import register


why the previous approach was wrong?

This is using reorder_python_imports, the same as pytest

please revert this. Let's have a PR with one objective, if we want to introduce a new tool to this project it should be a separate PR where we can discuss that.

@youtux I've reverted the change to use reorder-python-imports, and will make it an a followup

skarzi · 2020-12-23T17:34:27Z

And add 3.9 to CI?

3.9 is already tested by CI pipeline, however, 3.10 is missing in .travis.yml and tox.ini

tox.ini

tests/test_factory_fixtures.py

tests/test_lazy_fixture.py

This reverts commit f837871.

This reverts commit 48d56a0.

pytest_factoryboy/fixture.py

youtux · 2020-12-26T16:39:13Z

setup.cfg

+    Topic :: Software Development :: Libraries
+    Topic :: Utilities
+    Programming Language :: Python :: 3
+    Programming Language :: Python :: 3 :: Only


Please remove this classifier.

setup.cfg

pytest_factoryboy/fixture.py

graingert requested a review from hugovk December 23, 2020 10:31

skarzi mentioned this pull request Dec 23, 2020

update supported python and pytest versions #104

Merged

hugovk approved these changes Dec 23, 2020

View reviewed changes

setup.py Outdated Show resolved Hide resolved

youtux requested changes Dec 23, 2020

View reviewed changes

.travis.yml Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

pytest_factoryboy/fixture.py Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

tox.ini Outdated Show resolved Hide resolved

graingert added 4 commits December 23, 2020 14:38

apply black to docs/conf.py

aa1dbf8

pre-commit autoupdate

76e4497

configure pyupgrade

3d16f97

apply pyupgrade

2613ae4

graingert force-pushed the drop-support-for-eol-pythons branch from bdd2b89 to 330852b Compare December 23, 2020 14:42

graingert added 3 commits December 23, 2020 15:05

drop support for EOL pythons

a81d279

run pre-commit in ci

0ced339

apply setup-py-upgrade

1c664cb

graingert force-pushed the drop-support-for-eol-pythons branch from 330852b to 1c664cb Compare December 23, 2020 15:11

youtux reviewed Dec 23, 2020

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

graingert commented Dec 23, 2020

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

only use the lowest target-version for black

bfc7199

graingert requested review from hugovk and youtux December 23, 2020 15:35

youtux requested changes Dec 23, 2020

View reviewed changes

graingert changed the title ~~apply black to docs/conf.py~~ drop support for EOL python 2 Dec 23, 2020

graingert added 2 commits December 23, 2020 16:42

configure reorder-python-imports

48d56a0

apply reorder_python_imports

f837871

hugovk approved these changes Dec 23, 2020

View reviewed changes

graingert requested a review from youtux December 23, 2020 17:03

skarzi reviewed Dec 23, 2020

View reviewed changes

test with py3.10

1092c56

skarzi reviewed Dec 23, 2020

View reviewed changes

tox.ini Show resolved Hide resolved

ignore py310-pytestmaster outcome

2ec4b22

skarzi suggested changes Dec 24, 2020

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

graingert commented Dec 24, 2020

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

Update tox.ini

ebd4ab1

skarzi approved these changes Dec 24, 2020

View reviewed changes

youtux reviewed Dec 26, 2020

View reviewed changes

tests/test_factory_fixtures.py Outdated Show resolved Hide resolved

youtux reviewed Dec 26, 2020

View reviewed changes

tests/test_lazy_fixture.py Outdated Show resolved Hide resolved

graingert added 3 commits December 26, 2020 16:01

Revert "apply reorder_python_imports"

e9b1791

This reverts commit f837871.

Revert "configure reorder-python-imports"

a4a5f53

This reverts commit 48d56a0.

remove pre-commit from tox, we use pre-commit.ci

ddf0ecd

graingert requested a review from youtux December 26, 2020 16:07

youtux requested changes Dec 26, 2020

View reviewed changes

graingert commented Dec 26, 2020

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

diverge from pytest on trove classifiers

510344d

graingert commented Dec 27, 2020

View reviewed changes

pytest_factoryboy/fixture.py Outdated Show resolved Hide resolved

graingert commented Dec 27, 2020

View reviewed changes

pytest_factoryboy/fixture.py Outdated Show resolved Hide resolved

merge import of inspect.getmodule and inspect.signature

067081d

youtux merged commit 72eb55b into pytest-dev:master Dec 30, 2020

		from .fixture import LazyFixture
		from .fixture import register

drop support for EOL python 2 #105

drop support for EOL python 2 #105

Uh oh!

Conversation

graingert commented Dec 23, 2020 • edited by bubenkoff Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skarzi commented Dec 23, 2020

Uh oh!

skarzi commented Dec 23, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

graingert commented Dec 23, 2020

Uh oh!

hugovk commented Dec 23, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skarzi commented Dec 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

graingert commented Dec 23, 2020 •

edited by bubenkoff

Loading