Skip to content

Add pyproject.toml#26

Merged
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom
tucked:master
Oct 16, 2019
Merged

Add pyproject.toml#26
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom
tucked:master

Conversation

@tucked
Copy link
Copy Markdown
Contributor

@tucked tucked commented Oct 14, 2019

There are no wheels ATM for 1.1.0 or 1.1.1. That means pip needs to build one, and, since this package uses setup_requires, that means easy_install will be used to fetch setuptools_scm. That is a problem for our CI for embarrassing reasons. We do have an updated pip, though, so if there were a pyproject.toml, we could probably build successfully. So, here it is...

I would also appreciate it if someone would upload a wheel for the newest version(s). It looks like that was the intention anyways:

distributions: sdist bdist_wheel

(It doesn't look like that behaved correctly, though: https://travis-ci.org/pytest-dev/pytest-forked/jobs/596284457#L377)

@bt-thiago
Copy link
Copy Markdown

We have also been affected by the 1.1.x upgrade as our build environments don't allow direct access to the Internet. All builds use an internal Nexus 3 pypi proxy and easy_install isn't aware of the pip configuration.

So thanks for contributing the PR. We'll unpin the package version once it's merged and released.

Collecting pytest-forked (from pytest-xdist->-r requirements3.txt (line 7))
  Downloading https://<internal-url-redacted>/repository/pypi-all/packages/ae/9c/8f0c51c98ee5165ff575f196662a4a314ff07c9d3de64a94580c982edcee/pytest-forked-1.1.1.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-_p9i19vx/pytest-forked/setup.py'"'"'; __file__='"'"'/tmp/pip-install-_p9i19vx/pytest-forked/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
         cwd: /tmp/pip-install-_p9i19vx/pytest-forked/
    Complete output (26 lines):
    Download error on https://pypi.org/simple/setuptools_scm/: [Errno 101] Network is unreachable -- Some packages may not be found!
    Download error on https://pypi.org/simple/setuptools-scm/: [Errno 101] Network is unreachable -- Some packages may not be found!
    Couldn't find index page for 'setuptools_scm' (maybe misspelled?)
    Download error on https://pypi.org/simple/: [Errno 101] Network is unreachable -- Some packages may not be found!
    No local packages or working download links found for setuptools_scm

Comment thread pyproject.toml
@@ -0,0 +1,3 @@
[build-system]
requires = ['setuptools ~= 41.4', 'setuptools_scm ~= 3.3', 'wheel ~= 0.33.6']
build-backend = 'setuptools.build_meta'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pypa/setuptools/blob/master/setuptools/build_meta.py#L105 ensures this wont break/supports old metadata

this note is for myself

@untitaker
Copy link
Copy Markdown
Contributor

@RonnyPfannschmidt do we just want to merge this and hope travis does the right thing next time? I honestly don't know what this does

@RonnyPfannschmidt RonnyPfannschmidt merged commit b1b4ac8 into pytest-dev:master Oct 16, 2019
@RonnyPfannschmidt
Copy link
Copy Markdown
Member

i'll sort out the fallout of this one as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants