Add pyproject.toml#26
Merged
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom Oct 16, 2019
Merged
Conversation
|
We have also been affected by the 1.1.x upgrade as our build environments don't allow direct access to the Internet. All builds use an internal Nexus 3 pypi proxy and So thanks for contributing the PR. We'll unpin the package version once it's merged and released. |
RonnyPfannschmidt
approved these changes
Oct 15, 2019
| @@ -0,0 +1,3 @@ | |||
| [build-system] | |||
| requires = ['setuptools ~= 41.4', 'setuptools_scm ~= 3.3', 'wheel ~= 0.33.6'] | |||
| build-backend = 'setuptools.build_meta' | |||
Member
There was a problem hiding this comment.
https://github.com/pypa/setuptools/blob/master/setuptools/build_meta.py#L105 ensures this wont break/supports old metadata
this note is for myself
Contributor
|
@RonnyPfannschmidt do we just want to merge this and hope travis does the right thing next time? I honestly don't know what this does |
Member
|
i'll sort out the fallout of this one as needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no wheels ATM for 1.1.0 or 1.1.1. That means
pipneeds to build one, and, since this package usessetup_requires, that meanseasy_installwill be used to fetchsetuptools_scm. That is a problem for our CI for embarrassing reasons. We do have an updatedpip, though, so if there were apyproject.toml, we could probably build successfully. So, here it is...I would also appreciate it if someone would upload a wheel for the newest version(s). It looks like that was the intention anyways:
pytest-forked/.travis.yml
Line 30 in dd42fd1
(It doesn't look like that behaved correctly, though: https://travis-ci.org/pytest-dev/pytest-forked/jobs/596284457#L377)