Skip to content

Conversation

@pengyunie
Copy link
Contributor

GitHub workflow's ubuntu-latest now points to 24.04, where Python 3.7 is not available any more.
To fix it, I changed the CI config to let Python 3.7 use ubuntu-22.04. Other versions (3.8, 3.9. 3.10) stay the same.

It has been a few years since we published pytest-inline. I'm planning to do the following upgrades to CI / build config recently, let me know if there is any objections:

  1. Add CI tests for newer Python versions (3.11 -- 3.14)
  2. Upgrade the build and test toolchain to use uv, which should replace conda and tox
  3. We should consider dropping support for older Python versions (3.7, 3.8, 3.9, which are all end of life by now) at some point

@pengyunie pengyunie requested a review from Copilot November 14, 2025 20:40
Copilot finished reviewing on behalf of pengyunie November 14, 2025 20:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI failure caused by Python 3.7 no longer being available on ubuntu-latest (which now points to Ubuntu 24.04). The solution pins Python 3.7 to Ubuntu 22.04 while keeping other Python versions on the latest Ubuntu release.

  • Updated the GitHub Actions workflow to use a dynamic runs-on configuration based on the Python version
  • Added a matrix configuration to specify Ubuntu 22.04 for Python 3.7 tests
  • Maintained support for Python 3.8, 3.9, and 3.10 on ubuntu-latest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +14 to +16
python-version: ['3.8', '3.9', '3.10']
runs-on: [ubuntu-latest]
include:
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] "The matrix configuration will create unintended duplicate job runs. With the current structure, Python versions 3.8, 3.9, and 3.10 will each run on ubuntu-latest (as intended), but then Python 3.7 will be added as an additional job. However, because both python-version and runs-on are defined as matrix dimensions, this creates a cartesian product: 3 Python versions × 1 OS = 3 jobs, plus 1 job from the include. The configuration is correct as-is. To make it clearer, you could restructure to avoid having runs-on as a matrix variable and instead only use include entries, like this:

matrix:
fail-fast: false
include:
```suggestion
        include:
          - python-version: '3.8'
            runs-on: ubuntu-latest
          - python-version: '3.9'
            runs-on: ubuntu-latest
          - python-version: '3.10'
            runs-on: ubuntu-latest

Copilot uses AI. Check for mistakes.
@pengyunie pengyunie merged commit a200cd3 into pytest-dev:main Nov 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant