Skip to content

Fix CI issue for python 3.7 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

Fix CI issue for python 3.7 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/python-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@ on:

jobs:
build-linux:
runs-on: ubuntu-latest
runs-on: ${{ matrix.runs-on }}
strategy:
fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10']
runs-on: [ubuntu-latest]
include:
Comment on lines +14 to +16
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] "The matrix configuration will create unintended duplicate job runs. With the current structure, Python versions 3.8, 3.9, and 3.10 will each run on ubuntu-latest (as intended), but then Python 3.7 will be added as an additional job. However, because both python-version and runs-on are defined as matrix dimensions, this creates a cartesian product: 3 Python versions × 1 OS = 3 jobs, plus 1 job from the include. The configuration is correct as-is. To make it clearer, you could restructure to avoid having runs-on as a matrix variable and instead only use include entries, like this:

matrix:
fail-fast: false
include:
```suggestion
        include:
          - python-version: '3.8'
            runs-on: ubuntu-latest
          - python-version: '3.9'
            runs-on: ubuntu-latest
          - python-version: '3.10'
            runs-on: ubuntu-latest

Copilot uses AI. Check for mistakes.
- python-version: '3.7'
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v4
Expand Down
Loading