-
-
Notifications
You must be signed in to change notification settings - Fork 70
Pyside2 support (continued..) #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b59932a to
d147bdc
Compare
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
@The-Compiler would you like to take a look as well?
|
Seems fine from a very quick look, though I've never used PySide2. |
|
OK, merging then. Thanks @rth! I will make a new release later today or during the weekend! |
|
Thanks for the quick review @nicoddemus and @The-Compiler ! |
|
@rth I usually announce releases on twitter and I would like to mention you if you don't mind. If you don't, what's your twitter username? |
|
@nicoddemus Sure, it's |
|
Released! 👍 Thanks again @rth! |
Continuation of #161 by @fabioz aiming to add PySide2 support.
This PR,
test_wait_signal.py::test_destroyedfor PySide* as I have not managed to make this change pass CI (see test_wait_signal.py::test_destroyed and PySide #183).