Skip to content

Conversation

@rth
Copy link
Contributor

@rth rth commented Sep 15, 2017

Continuation of #161 by @fabioz aiming to add PySide2 support.

This PR,

@coveralls
Copy link

coveralls commented Sep 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b59932a on rth:pyside2-support into aa70124 on pytest-dev:master.

@coveralls
Copy link

coveralls commented Sep 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d147bdc on rth:pyside2-support into aa70124 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@The-Compiler would you like to take a look as well?

@The-Compiler
Copy link
Member

Seems fine from a very quick look, though I've never used PySide2.

@nicoddemus
Copy link
Member

nicoddemus commented Sep 15, 2017

OK, merging then. Thanks @rth!

I will make a new release later today or during the weekend!

@nicoddemus nicoddemus merged commit ba54c68 into pytest-dev:master Sep 15, 2017
@rth rth deleted the pyside2-support branch September 15, 2017 13:01
@rth
Copy link
Contributor Author

rth commented Sep 15, 2017

Thanks for the quick review @nicoddemus and @The-Compiler !

@nicoddemus
Copy link
Member

@rth I usually announce releases on twitter and I would like to mention you if you don't mind. If you don't, what's your twitter username?

@rth
Copy link
Contributor Author

rth commented Sep 15, 2017

@nicoddemus Sure, it's RomanYurchak. Thank you!

@nicoddemus
Copy link
Member

Released! 👍

Thanks again @rth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants