Pass a type instead of string to parser.addoption #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get this DeprecationWarning with pytest 3.0:
[...]
File ".../pytest_rerunfailures.py", line 18, in pytest_addoption
help="number of times to re-run failed tests. defaults to 0.")
File ".../_pytest/config.py", line 482, in addoption
self._anonymous.addoption(*opts, **attrs)
File ".../_pytest/config.py", line 708, in addoption
option = Argument(*optnames, **attrs)
File ".../_pytest/config.py", line 609, in __init__
stacklevel=3)
DeprecationWarning: type argument to addoption() is a string 'int'. For parsearg this should be a type. (options: ('--reruns',))
Contributor
|
👍 |
Contributor
|
@florianpilz r? |
Contributor
|
@davehunt We have an company-internal sprint today, I thought delaying the response for 2 days does not make anyone uneasy. ;) |
Contributor
|
@The-Compiler Thanks for fixing this proactively! |
Member
Author
|
You're welcome! Note that pytest 3.0 is hopefully going to be released very soon (this week? next week?) - having a new release before that would be most appreciated! |
Contributor
|
Released in 2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get this DeprecationWarning with pytest 3.0: