fixtures: fix incorrect "duplicate parametrization" when using indirect=[...]

The code in `_get_direct_parametrize_args` only handled
`indirect=True/False`, it didn't account for `indirect=[...]`. This
caused the added test to start failing after
d56b1af.

Fix by using the common `_resolve_args_directness` function. It's a bit
heavy for the task but correctness first...

Fix #13974.

Author: bluetech

src/_pytest/fixtures.py

@@ -1523,11 +1523,16 @@ def _get_direct_parametrize_args(node: nodes.Node) -> set[str]:
     """
     parametrize_argnames: set[str] = set()
     for marker in node.iter_markers(name="parametrize"):
-        if not marker.kwargs.get("indirect", False):
-            p_argnames, _ = ParameterSet._parse_parametrize_args(
-                *marker.args, **marker.kwargs
-            )
-            parametrize_argnames.update(p_argnames)
+        indirect = marker.kwargs.get("indirect", False)
+        p_argnames, _ = ParameterSet._parse_parametrize_args(
+            *marker.args, **marker.kwargs
+        )
+        p_directness = _resolve_args_directness(p_argnames, indirect, node.nodeid)
+        parametrize_argnames.update(
+            argname
+            for argname, directness in p_directness.items()
+            if directness == "direct"
+        )
     return parametrize_argnames
 
 

testing/python/collect.py

@@ -524,6 +524,42 @@ def test_overridden_via_param(value):
         rec = pytester.inline_run()
         rec.assertoutcome(passed=1)
 
+    def test_parametrize_overrides_parametrized_fixture_with_unrelated_indirect(
+        self, pytester: Pytester
+    ) -> None:
+        """Test parametrization when parameter overrides existing parametrized fixture with same name,
+        and there is an unrelated indirect param.
+
+        Regression test for #13974.
+        """
+        pytester.makepyfile(
+            """
+            import pytest
+
+            @pytest.fixture(params=["a", "b"])
+            def target(request):
+                return request.param
+
+            @pytest.fixture
+            def val(request):
+                return int(request.param)
+
+            @pytest.mark.parametrize(
+                ["val", "target"],
+                [
+                    ("1", 1),
+                    ("2", 2),
+                ],
+                indirect=["val"],
+            )
+            def test(val, target):
+                assert val == target
+            """
+        )
+        result = pytester.runpytest()
+        assert result.ret == 0
+        result.assert_outcomes(passed=2)
+
     def test_parametrize_overrides_indirect_dependency_fixture(
         self, pytester: Pytester
     ) -> None: