Skip to content

Conversation

RonnyPfannschmidt
Copy link
Member

  • print each distribution only once(xdist now has 3 entrypoints)
  • include the distribution version

* print each distribution only once(xdist now has 3 entrypoints)
* include the distribution version
@RonnyPfannschmidt RonnyPfannschmidt assigned flub and pfctdayelise and unassigned flub Aug 8, 2015
@pfctdayelise
Copy link
Contributor

OK so I just pip-installed xdist, I guess I don't have the version that would cause duplication on master. But having plugin version info definitely seems like a good idea.

Master:

platform linux2 -- Python 2.7.6, pytest-2.8.0.dev4, py-1.4.30, pluggy-0.3.0
rootdir: /home/brianna/workspace/pytest, inifile: tox.ini
plugins: xdist

this branch:

platform linux2 -- Python 2.7.6, pytest-2.8.0.dev4, py-1.4.30, pluggy-0.3.0
rootdir: /home/brianna/workspace/pytest, inifile: tox.ini
plugins: xdist 1.12

@pfctdayelise
Copy link
Contributor

I imagine it's a pain to install a plugin in a test, but could we make a test? Or do you think because this gets exercised so much it's not worth it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this was joined by a dash rather than space, for consistency with the builtin plugins on line 281.

getpluginversioninfo suggests you can do dist.project_name, dist.version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, thanks

@RonnyPfannschmidt
Copy link
Member Author

will reopen from a branch, made it from master by accident (thanks git)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants