Skip to content

adapt plugin printing #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

adapt plugin printing #928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions _pytest/terminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,15 @@ def pytest_report_header(self, config):
if plugininfo:
l = []
for plugin, dist in plugininfo:
name = dist.project_name
# gets us name and version!
name = str(dist)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this was joined by a dash rather than space, for consistency with the builtin plugins on line 281.

getpluginversioninfo suggests you can do dist.project_name, dist.version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, thanks

# questionable convenience, but it keeps things short
if name.startswith("pytest-"):
name = name[7:]
l.append(name)
# we decided to print python package names
# they can have more than one plugin
if name not in l:
l.append(name)
lines.append("plugins: %s" % ", ".join(l))
return lines

Expand Down