chore(price-feeds): pf add etherlink, remove entropy for etherlink existing testnet #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nidhi-singh02
commented
Oct 24, 2025
| | Dela Deperp Mithreum Testnet | <CopyAddress address="0xe9d69CdD6Fe41e7B621B4A688C5D1a68cB5c8ADc" url="https://mithreum-sepolia.deperp.com/address/0xe9d69CdD6Fe41e7B621B4A688C5D1a68cB5c8ADc" /> | | ||
| | EOS testnet | <CopyAddress address="0x0708325268dF9F66270F1401206434524814508b" url="https://explorer.testnet.evm.eosnetwork.com/address/0x0708325268dF9F66270F1401206434524814508b" /> | | ||
| | Etherlink testnet | <CopyAddress address="0x2880aB155794e7179c9eE2e38200202908C17B43" url="https://testnet.explorer.etherlink.com/address/0x2880aB155794e7179c9eE2e38200202908C17B43" /> | | ||
| | Etherlink Ghostnet testnet | <CopyAddress address="0x2880aB155794e7179c9eE2e38200202908C17B43" url="https://testnet.explorer.etherlink.com/address/0x2880aB155794e7179c9eE2e38200202908C17B43" /> | |
There was a problem hiding this comment.
add the testnet name to identify.
ali-behjati
approved these changes
Oct 24, 2025
|
|
||
| const sortedDeployments = Object.entries(deployments).sort(); | ||
| const sortedDeployments = Object.entries(deployments) | ||
| .filter(([name]) => name !== "etherlink-testnet") |
There was a problem hiding this comment.
i'm worried we forget about it in the future and later come and see this and be like oh why did we do this? :D i think it's just ok to remove it.
There was a problem hiding this comment.
AFAIK this data is coming from Fortuna API. Wondering how it can be removed ? If there's a way, let's get this removed instead of this workaround.
There was a problem hiding this comment.
@nidhi-singh02 explained to me that this comes from fortuna api. let's keep it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots