Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danimhr
commented
Apr 8, 2025
| order_address: _order_address, | ||
| slot: _slot, | ||
| } => { | ||
| // let deadline = (OffsetDateTime::now_utc() + Duration::days(1)).unix_timestamp(); |
Contributor
Author
There was a problem hiding this comment.
Actually it's needed :D
guibescos
reviewed
Apr 8, 2025
| { | ||
| "name": "@pythnetwork/express-relay-js", | ||
| "version": "0.24.0", | ||
| "version": "0.25.0", |
Contributor
There was a problem hiding this comment.
I believe it's better to bump just before releasing, otherwise some else doing another change might also bump and we would skip a version?
Contributor
Author
There was a problem hiding this comment.
Makes sense. Updated
guibescos
approved these changes
Apr 8, 2025
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
Please update the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add minimum deadline field to opportunity type of the sdks