feat: Remove generics from opportunity service#505
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
danimhr
reviewed
Apr 14, 2025
| mod remove_opportunities; | ||
| mod remove_opportunity; | ||
|
|
||
| use crate::opportunity::entities::OpportunitySvm; |
Contributor
There was a problem hiding this comment.
Maybe it's better to not important the object. You may import the entities and then use entities::OpportunitySvm
| reason = ?reason, | ||
| "Removing Opportunity", | ||
| ); | ||
| match self.repo.remove_opportunity(opportunity, reason).await { |
Contributor
There was a problem hiding this comment.
What happened to the remove opportunity logic here?
Contributor
Author
There was a problem hiding this comment.
wrong way, good catch
Dewyer
force-pushed
the
feat/un-generic-oportunity-service
branch
from
6cacbff to
8577c61
Compare
Dewyer
force-pushed
the
feat/un-generic-oportunity-service
branch
from
8577c61 to
8fc6ab0
Compare
danimhr
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.