Skip to content

ensure consumers get a unique ephemeral name #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

ensure consumers get a unique ephemeral name #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c66163
ensure consumers get a unique ephemeral name
ayazabbas Oct 23, 2024
71d594e
set stream max_bytes to 4 GB
ayazabbas Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pyth-stream"
version = "0.1.6"
version = "0.1.7"
edition = "2021"

[lib]
Expand Down
13 changes: 3 additions & 10 deletions src/bin/websocket_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,10 @@ struct PriceInfo {

async fn handle_nats_messages(jetstream: jetstream::Context, clients: Clients) -> Result<()> {
let stream_name = "PYTH_PRICE_UPDATES";
let consumer_name = "websocket_server";

let consumer_config = consumer::pull::Config {
durable_name: Some(consumer_name.to_string()),
deliver_policy: consumer::DeliverPolicy::All,
ack_policy: consumer::AckPolicy::None,
..Default::default()
};

Expand All @@ -280,7 +280,7 @@ async fn handle_nats_messages(jetstream: jetstream::Context, clients: Clients) -
.await
.context("Failed to create NATS consumer")?;

info!(stream = %stream_name, consumer = %consumer_name, "Started handling NATS messages");
info!(stream = %stream_name, "Started handling NATS messages");

loop {
let mut messages = consumer
Expand Down Expand Up @@ -336,13 +336,6 @@ async fn handle_nats_messages(jetstream: jetstream::Context, clients: Clients) -
);
}
}

// Spawn a new task for acknowledgment
tokio::spawn(async move {
if let Err(e) = msg.ack().await {
warn!(error = %e, "Failed to acknowledge NATS message");
}
});
}
Err(e) => {
error!(error = %e, "Error receiving message from NATS");
Expand Down