Support for native BPM CS aggregator#118
Merged
JeanLucPons merged 7 commits intomainfrom Jan 15, 2026
Merged
Conversation
Merged
Contributor
gubaidulinvadim
left a comment
There was a problem hiding this comment.
This looks fine to me. I think it will be good to specify in the docstring that by native backend we mean that the underlying Device / PV implement an array of positions for many BPMs. (If I understand this correctly). I would like if @gupichon will also confirm that it is ok to merge because we wanted to fix the version to be used at the workshop.
Contributor
Author
|
OK. It will be nice to update the native tango-backend before fixing release for the workshop otherwise orbit correction on the bessy VA will not be possible with main pyaml branch. |
gupichon
requested changes
Jan 15, 2026
Contributor
gupichon
left a comment
There was a problem hiding this comment.
Small error in the yaml test file a "/" is missing.
tests/config/bpms.yaml
Outdated
| y_pos_index: 1 | ||
| x_pos: | ||
| type: tango.pyaml.attribute_read_only | ||
| attribute: srdiag/bpm/c01-04Position |
gupichon
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for native BPM aggregator.
It also include support for needed vector variable and bring an incompatibly with the tango native backend due to the new function
attach_array()to be implemented.pyaml_cs_oabackend is already up-to-date.Please merge #123 and tag to 0.2.1 before merging this PR.