Merged
Conversation
Contributor
gubaidulinvadim
left a comment
gubaidulinvadim
left a comment
There was a problem hiding this comment.
I could only check that the existing tests run without errors. But there are no new tests. Minor point: I also don't fully understand why element_holder is located in the 'lattice' when it (element_holder) is common for the simulator and the control system.
Contributor
Author
|
element_holder is indeed common to simulator and control system. |
Contributor
Author
|
@gupichon Could you approve this PR ? Thanks |
Contributor
|
I agree with @gubaidulinvadim , adding some tests would have been helpful. Maybe later? |
gupichon
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing magnet arrays