Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Conversation

@jonringer
Copy link
Contributor

Noticed this was broken on nixpkgs/master because of an update to scipy.

In scipy 1.3, they removed scipy.misc.factorial and instead, only scipy.math.factorial remains.

Because math is just a class, and not a module, I couldn't emulate a similar from ... import factorial :(

@FRidh FRidh merged commit 67b4443 into python-acoustics:master Jun 20, 2019
@FRidh
Copy link
Member

FRidh commented Jun 20, 2019

Thank you.

@FRidh
Copy link
Member

FRidh commented Jun 20, 2019

Requiring 1.3 is actually not acceptable. I merged it without considering that. Due to another change I force-pushed removing the commit.

FRidh added a commit that referenced this pull request Jun 20, 2019
@jonringer
Copy link
Contributor Author

I should have added that I was able to pass your test suite with 1.2.1. I think the scipy.misc module was never meant to be stable.

But your changes seem to make this irrelevant.

scipy is just re-exporting stuff from numpy, so if you really wanted to, you could just change it to

from numpy import math
factorial = math.factorial

and I'm assuming that would be more stable. But I haven't really used either, so what do i know :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants