This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Avoid scipy 1.3 breaking factorial import path #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this was broken on nixpkgs/master because of an update to scipy.
In scipy 1.3, they removed
scipy.misc.factorialand instead, onlyscipy.math.factorialremains.Because
mathis just a class, and not a module, I couldn't emulate a similarfrom ... import factorial:(