-
Notifications
You must be signed in to change notification settings - Fork 62
Remove _choose_points #121
Copy link
Copy link
Closed
Description
(original issue on GitLab)
opened by Joseph Weston (@jbweston) at 2017-09-06T12:36:23.370Z
Currently there is choose_points, which just calls _choose_points and adds (or not) the data to self.data.
There are several examples (BalancingLearner and 2DLearner) where it makes most sense to implement choose_points directly.
Even in this case we still need to
def _choose_points(self, n):
pass
because it is labelled as an abstract method.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels