Skip to content

Remove _choose_points #121

@jbweston

Description

@jbweston

(original issue on GitLab)

opened by Joseph Weston (@jbweston) at 2017-09-06T12:36:23.370Z

Currently there is choose_points, which just calls _choose_points and adds (or not) the data to self.data.

There are several examples (BalancingLearner and 2DLearner) where it makes most sense to implement choose_points directly.

Even in this case we still need to

def _choose_points(self, n):
    pass

because it is labelled as an abstract method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions