Validate init aliases before generated code compilation#1556
Open
uwezkhan wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attrs generates init methods dynamically using field aliases. currently invalid aliases can make it all the way into generated source code and fail later during compilation with confusing SyntaxError exceptions.
this change adds validation for init aliases before code generation happens. it checks for invalid identifiers, python keywords, reserved names like self and unicode normalization collisions that can result in duplicate generated parameter names.
validation happens after alias resolution and field transformers run so all final aliases are checked consistently before generating the initializer.
added regression tests for:
invalid identifiers
keyword aliases
self shadowing
unicode normalization collisions
init=False behavior