Match filter attributes by identity#1559
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #864 by making
attrs.filters.include()andattrs.filters.exclude()matchattrs.Attributeobjects by identity instead of equality.Root Cause
attrs.Attributeequality does not carry owning-class identity, so fields with the same name and otherwise equal metadata on different classes compare equal. Passingattrs.fields(SomeClass).fieldto a filter could therefore include or exclude same-named fields from unrelated classes during recursiveasdict()conversion.Changes
Attributefilter arguments as an ordered tuple instead of afrozenset.Attributearguments withisidentity checks.include()andexclude().Validation
.venv/bin/python -m pytest -q tests/test_filters.py-> 35 passed.venv/bin/python -m pytest -q tests/test_filters.py -k "identity or split_what"-> 2 passed, 33 deselected.venv/bin/python -m pytest -q-> 1387 passed, 5 skipped, 1 xfailed.venv/bin/ruff check src/attr/filters.py tests/test_filters.py docs/examples.md.venv/bin/ruff format --check src/attr/filters.py tests/test_filters.py.venv/bin/python -m compileall -q src/attr/filters.py tests/test_filters.pygit diff --check origin/main...HEAD