Add input type validation to max_len and min_len validators to preven…#1561
Open
uwezkhan wants to merge 2 commits into
Open
Add input type validation to max_len and min_len validators to preven…#1561uwezkhan wants to merge 2 commits into
uwezkhan wants to merge 2 commits into
Conversation
…t crashes on non-sized objects
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max_len and min_len validators called len() on input values without checking if they support the len() function. This causes cryptic TypeError: object of type 'X' has no len() when non-sized objects are passed. Example of the Problem: @attr.s class Example: items = attr.ib(validator=max_len(10)) # This raises confusing error: # TypeError: object of type 'generator' has no len() Example(items=(x for x in range(5))) Why This Matters: Reliability - Prevents confusing TypeErrors hard to debug Validation - Catches invalid inputs early with clear messages Consistency - Follows validation patterns in other validators Solution Added explicit type validation using isinstance(value, collections.abc.Sized): _MaxLengthValidator validates input is Sized before calling len() _MinLengthValidator validates input is Sized before calling len() Raises clear TypeError: '<attr_name>' must be a sized object (got that is a ).