Apply demorgan's laws to simplify load code#371
Open
sixolet wants to merge 1 commit intopython-babel:masterfrom
Open
Apply demorgan's laws to simplify load code#371sixolet wants to merge 1 commit intopython-babel:masterfrom
sixolet wants to merge 1 commit intopython-babel:masterfrom
Conversation
Previously, the load code contained two branches on either side of an unconditional file load. Their predicates were the exact opposite of each other, according to Demorgan's laws. Clarify the code by replacing the two confusing branches with one clearer branch. This does not change functionality; there's no relevant bug in the system.
Current coverage is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the load code contained two branches on either side of an
unconditional file load. Their predicates were the exact opposite of each
other, according to Demorgan's laws.
Clarify the code by replacing the two confusing branches with one clearer
branch.
This does not change functionality; there's no relevant bug in the system.