Make all test threads daemons to keep CI/CD from hanging.#119
Merged
Make all test threads daemons to keep CI/CD from hanging.#119
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 5 5
Lines 477 477
Branches 76 76
=======================================
Hits 467 467
Misses 7 7
Partials 3 3 Continue to review full report in Codecov by Sentry.
|
Member
|
Yeah, definitely can't hurt. I guess only time will tell if this solved the problem. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hanging threads is my suspicion as to what's causes tests to get stuck sometimes. Making all test threads daemons means they'll be terminated when the tests end.
I'm not entirely sure this will correct #118 , but it shouldn't hurt. I'll give it a few days of successful CI/CD runs before closing the issue.