Enable separation of MongoDB tests from other tests #144
Conversation
shaypal5
force-pushed
the
enable-mongo-separation
branch
from
232a37c to
6b5ad19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 5 5
Lines 508 508
Branches 88 88
=======================================
Hits 505 505
Misses 2 2
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
| 'mongetter,backend', | ||
| [ | ||
| (_test_mongetter, 'mongo'), | ||
| # (_test_mongetter, 'mongo'), # Please do NOT test the mongo backend |
There was a problem hiding this comment.
why not rather mark it with
pytest.param(_test_mongetter, 'mongo', marks=pytest.mark.mongo)
instead of duplicating whole test
There was a problem hiding this comment.
Oops. I didn't know you're going to review in time. :P
Anyway, I didn't know you could do that with pytest!
Let's try that later. You can work it into your suite separation PR, or later; I'm not sure I understand the exact syntax you refer to.
There was a problem hiding this comment.
seems that this parameter marking was already used in the tests, see: #145
No description provided.