Skip to content

use pytest.param instead of copy whole test #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2024
Merged

use pytest.param instead of copy whole test #145

merged 4 commits into from
Feb 2, 2024

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Feb 1, 2024

suggestion from #144 (comment)

@codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d19b3cf) 99.40% compared to head (84b753c) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #145      +/-   ##
===========================================
+ Coverage   99.40%   100.00%   +0.59%     
===========================================
  Files           5         5              
  Lines         508       508              
  Branches       88        88              
===========================================
+ Hits          505       508       +3     
+ Misses          2         0       -2     
+ Partials        1         0       -1

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19b3cf...84b753c. Read the comment docs.

@shaypal5 shaypal5 changed the base branch from master to pytest.param-origin February 2, 2024 10:19
@shaypal5 shaypal5 merged commit 0f260ca into python-cachier:pytest.param-origin Feb 2, 2024
shaypal5 added a commit that referenced this pull request Feb 2, 2024
@shaypal5
use pytest.param instead of copy whole test (#145) (#147)
9a68b3a 
use `pytest.param` instead of copy whole test
Authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>, just merged by Shay Palachy Affek
@Borda Borda deleted the pytest.param branch February 2, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Borda @shaypal5