Add recursion depth limit to prevent stack overflow in hash function#342
Merged
shaypal5 merged 2 commits intocodex/add-test-and-benchmark-for-numpy-array-performancefrom Feb 18, 2026
Conversation
…h check Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback from NumPy-aware hashing review
Add recursion depth limit to prevent stack overflow in hash function
Feb 18, 2026
b2ba0ba
into
codex/add-test-and-benchmark-for-numpy-array-performance
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recursive
_update_hash_for_valuefunction could cause stack overflow when hashing deeply nested data structures (lists, dicts, tuples).Changes
_update_hash_for_valuenow tracks recursion depth and enforces a configurable limit (default: 100 levels)RecursionErrorwith actionable guidance when limit is exceededtests/test_recursion_depth.pycovering edge cases for lists, dicts, and tuples at various nesting levelsBehavior
Normal nested structures continue to work:
Pathological cases now fail fast with clear guidance:
The implementation is backward compatible - new parameters use defaults that preserve existing behavior for typical use cases.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.