Extend isolated_cache_directory fixture to cover maxage-marked tests#354
Merged
shaypal5 merged 2 commits intotesting-improvementsfrom Feb 28, 2026
Merged
Extend isolated_cache_directory fixture to cover maxage-marked tests#354shaypal5 merged 2 commits intotesting-improvementsfrom
shaypal5 merged 2 commits intotesting-improvementsfrom
Conversation
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix precommit-ci errors in parallel testing
Extend isolated_cache_directory fixture to cover maxage-marked tests
Feb 28, 2026
shaypal5
approved these changes
Feb 28, 2026
shaypal5
added a commit
that referenced
this pull request
Mar 1, 2026
…354) * Initial plan * Extend isolated_cache_directory fixture to cover maxage-marked tests Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxagetests use@cachier.cachier()with the default pickle backend and no explicitcache_dir, making them susceptible to the same parallel-execution cache conflicts aspickle-marked tests — but theisolated_cache_directoryautouse fixture only guarded the latter.Changes
tests/conftest.py: Extendisolated_cache_directoryfixture activation condition to includemaxage-marked tests alongsidepickle-marked tests:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.