Skip to content

Conversation

@buddly27
Copy link
Contributor

No description provided.

@buddly27 buddly27 requested a review from Copilot November 17, 2025 23:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds environment variable support to the Sphinx documentation target by extending the sphinx_add_docs function with new parameters for configuring library paths, Python paths, and custom environment variables.

Key Changes:

  • Added support for LIBRARY_PATH_PREPEND, PYTHON_PATH_PREPEND, and ENVIRONMENT arguments to configure the build environment
  • Implemented platform-specific handling for library path environment variables (PATH on Windows, DYLD_LIBRARY_PATH on Darwin, LD_LIBRARY_PATH on others)
  • Modified the Sphinx build command to run within a configured environment using cmake -E env

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants