Skip to content

Conversation

@kmvanbrunt
Copy link
Member

@kmvanbrunt kmvanbrunt commented Mar 2, 2021

Fixes #1070

@kmvanbrunt kmvanbrunt requested a review from anselor as a code owner March 2, 2021 22:15
@kmvanbrunt kmvanbrunt self-assigned this Mar 2, 2021
@kmvanbrunt kmvanbrunt requested a review from tleonhardt March 2, 2021 22:15
@kmvanbrunt kmvanbrunt added the bug label Mar 2, 2021
@kmvanbrunt kmvanbrunt added this to the 2.0.0 milestone Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1069 (5732bc3) into master (cc9d96a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1069   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          22       22           
  Lines        4622     4624    +2     
=======================================
+ Hits         4540     4542    +2     
  Misses         82       82           
Impacted Files Coverage Δ
cmd2/argparse_completer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9d96a...5732bc3. Read the comment docs.

@kmvanbrunt kmvanbrunt force-pushed the completion_item_choices branch from 38c9a4e to 5732bc3 Compare March 2, 2021 22:21
@tleonhardt tleonhardt merged commit 462e162 into master Mar 3, 2021
@tleonhardt tleonhardt deleted the completion_item_choices branch March 3, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argparse choices can't be CompletionItems

3 participants