Skip to content

Conversation

@jayrod
Copy link
Contributor

@jayrod jayrod commented Jan 1, 2022

Based on the changes I've made I didn't think it made sense to keep the blurb concerning cmd2 plugin ext testing. But hopefully I added enough examples to get people going in the right direction.

@jayrod jayrod requested a review from tleonhardt as a code owner January 1, 2022 06:12
@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #1187 (1ab62d2) into master (081a06b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          22       22           
  Lines        5674     5674           
=======================================
  Hits         5592     5592           
  Misses         82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081a06b...1ab62d2. Read the comment docs.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the strict doc build test

Copy link
Member

@kmvanbrunt kmvanbrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. In regards to my comment about CommandResult.__bool__(), try to minimize or eliminate using if result.stderr: to check for errors and instead use if not result: if you can.

@tleonhardt
Copy link
Member

@jayrod Thanks for working to help improve the documentation! We would like to get this merged in whenever you can find the time to address the comments. Thanks agian!

@jayrod
Copy link
Contributor Author

jayrod commented Jan 23, 2022

Oh wow.. I have not received these messages. My apologies I'll work on this tonight.

@jayrod jayrod requested a review from tleonhardt January 23, 2022 20:27
@jayrod jayrod requested a review from kmvanbrunt January 25, 2022 00:38
@tleonhardt
Copy link
Member

@jayrod I have invited you to be a cmd2 contributor. This will make it much easier for you to contribute in the future and to collaborate with other developers. It will allow you to create branches in the main repo and create PRs directly off of those branches - so no need to use a fork from here on out.

@tleonhardt tleonhardt merged commit ebd6179 into python-cmd2:master Jan 26, 2022
@jayrod jayrod deleted the pyscript_documentation branch January 27, 2022 04:14
@jayrod
Copy link
Contributor Author

jayrod commented Jan 27, 2022

@jayrod I have invited you to be a cmd2 contributor. This will make it much easier for you to contribute in the future and to collaborate with other developers. It will allow you to create branches in the main repo and create PRs directly off of those branches - so no need to use a fork from here on out.

I appreciate the invite and I'll try to continue my contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants