-
Notifications
You must be signed in to change notification settings - Fork 124
Added substantial documentation concerning pyscript #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 22 22
Lines 5674 5674
=======================================
Hits 5592 5592
Misses 82 82 Continue to review full report at Codecov.
|
tleonhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the strict doc build test
kmvanbrunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. In regards to my comment about CommandResult.__bool__(), try to minimize or eliminate using if result.stderr: to check for errors and instead use if not result: if you can.
|
@jayrod Thanks for working to help improve the documentation! We would like to get this merged in whenever you can find the time to address the comments. Thanks agian! |
|
Oh wow.. I have not received these messages. My apologies I'll work on this tonight. |
|
@jayrod I have invited you to be a |
I appreciate the invite and I'll try to continue my contributions :) |
Based on the changes I've made I didn't think it made sense to keep the blurb concerning cmd2 plugin ext testing. But hopefully I added enough examples to get people going in the right direction.