Skip to content

Comments

Refactor input#1585

Merged
kmvanbrunt merged 24 commits intomainfrom
refactor_input
Feb 24, 2026
Merged

Refactor input#1585
kmvanbrunt merged 24 commits intomainfrom
refactor_input

Conversation

@kmvanbrunt
Copy link
Member

Moved logic specific to the main command line from Cmd.read_input() to Cmd._read_command_line().

No longer setting Cmd.session.input to a pipe since that causes warnings from prompt-toolkit.
For non-interactive sessions (self.stdin is a pipe), we use self.stdin.readline().

Added documentation for completion.py.
…o Cmd._read_command_line().

No longer setting Cmd.session.input to a pipe since that causes warnings from prompt-toolkit.
For non-interactive sessions (stdin is a pipe), we use stdin.readline().
@github-actions
Copy link
Contributor

🤖 Hi @kmvanbrunt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.17%. Comparing base (4f545de) to head (a300f10).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd2/cmd2.py 97.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   99.42%   99.17%   -0.25%     
==========================================
  Files          21       20       -1     
  Lines        4676     4616      -60     
==========================================
- Hits         4649     4578      -71     
- Misses         27       38      +11     
Flag Coverage Δ
unittests 99.17% <97.50%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

🤖 I'm sorry @kmvanbrunt, but I was unable to process your request. Please see the logs for more details.

@kmvanbrunt kmvanbrunt merged commit e38f0f7 into main Feb 24, 2026
46 of 48 checks passed
@kmvanbrunt kmvanbrunt deleted the refactor_input branch February 24, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants