Skip to content

Fixed a major bug in the pyscript command on Windows#162

Merged
tleonhardt merged 3 commits intomasterfrom
py_tests
Jul 2, 2017
Merged

Fixed a major bug in the pyscript command on Windows#162
tleonhardt merged 3 commits intomasterfrom
py_tests

Conversation

@tleonhardt
Copy link
Copy Markdown
Member

Also:

  • Updated CHANGES
  • Added a number of additional pyscript unit tests
  • Re-enabled a skipped pyscript unit test on Windows

Without using the repr representation of the path, "C:\Users" treats \U as a Unicode Escape.

To fix this, pyscript passes the repr representation of the path to do_py.
@tleonhardt tleonhardt added this to the 0.7.4 milestone Jul 2, 2017
@tleonhardt tleonhardt self-assigned this Jul 2, 2017
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2017

Codecov Report

Merging #162 into master will increase coverage by 0.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   90.93%   91.71%   +0.78%     
==========================================
  Files           1        1              
  Lines        1147     1147              
==========================================
+ Hits         1043     1052       +9     
+ Misses        104       95       -9
Impacted Files Coverage Δ
cmd2.py 91.71% <100%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d5b67...4e8c08e. Read the comment docs.

@tleonhardt tleonhardt merged commit 26743a7 into master Jul 2, 2017
@tleonhardt tleonhardt deleted the py_tests branch July 2, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant